Completed prototype development#1
Merged
Merged
Conversation
… (error when there is no default set).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial prototype release of the Nexus Certificate Manager AnyCA REST Gateway Plugin, enabling Keyfactor Command to integrate with Nexus Certificate Manager for certificate lifecycle management operations through the AnyCA Gateway framework.
Key changes:
- Implements complete CA plugin functionality including enrollment, synchronization, and revocation operations
- Adds REST API client with certificate-based authentication for Nexus Certificate Manager
- Creates configuration system with support for host URL, authentication certificate path, and password management
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 30 comments.
Show a summary per file
| File | Description |
|---|---|
| nexus-certificate-manager-caplugin/models/Helpers.cs | New file implementing helper methods for subject parsing, status code mapping, certificate extraction, and REST API response handling |
| nexus-certificate-manager-caplugin/models/ApiModels.cs | Extends existing API models with new request/response classes for certificate operations, including ListCertificatesRequest with query string builder and CertificateBinaryResponse |
| nexus-certificate-manager-caplugin/manifest.json | Updates plugin registration from DigiCert to Nexus Certificate Manager with new assembly path and type name |
| nexus-certificate-manager-caplugin/NexusCertManagerClient.cs | Implements REST API client for Nexus Certificate Manager with methods for enrollment, certificate retrieval, revocation, listing, and server ping |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPluginConfig.cs | Defines configuration properties for host, authentication certificate path and password, and enabled flag |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.csproj | Updates project to disable implicit usings, adds dependencies for Keyfactor.PKI and RestSharp, includes manifest.json in build output |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs | Implements IAnyCAPlugin interface with full implementation of enrollment, synchronization, revocation, validation, and configuration methods |
| nexus-certificate-manager-caplugin/Constants.cs | New file defining constant values for configuration keys, API paths, media types, and API endpoint definitions |
| integration-manifest.json | New file defining integration metadata including plugin name, status, configuration fields, and release details |
| docsource/configuration.md | New documentation file describing plugin overview, requirements, gateway registration, CA connection, and certificate template creation |
| NexusCertManagerCAPlugin.sln | Updates solution structure to include new documentation and manifest files in Solution Items |
| CHANGELOG.md | New file documenting version 1.0.0 initial release |
| .github/workflows/keyfactor-bootstrap-workflow.yml | New GitHub Actions workflow configuration for automated builds and releases |
Comments suppressed due to low confidence (1)
nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs:205
- This assignment to res is useless, since its value is never read.
var res = await _client.PingServer();
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flattening exception to retain potential useful info Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial release